Remove an invalid assertion that triggers fuzzers#1492
Remove an invalid assertion that triggers fuzzers#1492kleisauke wants to merge 1 commit intostrukturag:masterfrom
Conversation
|
Can you send me or attach the POC file? |
|
I've just send it to your privately as this is an issue in libvips. FWIW, this assertion failure also occurs on Fedora because the RPM spec files didn't pass |
|
Thanks, I'll have a closer look at the POC what the root cause for this is. |
@Conan-Kudo @rathann Sorry for the ping. I'm trying to determine the best approach for handling this from a packaging perspective. I noticed that the CMake macros pass However, this would only work when libheif is built with |
|
For libheif, there is also |
For Fedora packaging, the default build type should be |
See: strukturag/libheif#1492 (cherry picked from commit 5a6b8b8)
I can confirm that adding |
|
This issue has been resolved already in 014cb59 in the Thus, I propose that instead of removing the assertion that we wait for v1.20.0 where the invalid input is correctly detected. |
|
I have backported the fix into the master branch. |
|
Great! I can confirm that commit e2253ec fixes this. FWIW, issue https://issues.oss-fuzz.com/issues/404288018 is now public, which could help packagers verify if libheif was built with assertions enabled. |
Found by libvips' fuzz tests.
See: libvips/libvips#4424.